Do not complain about unmentioned fields in recovered patterns #59198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the parser has to recover from malformed code in a pattern, do not complain about missing fields.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @zackmdavis |
|
r? @davidtwco |
zackmdavis
reviewed
Mar 26, 2019
| @@ -4698,7 +4698,7 @@ impl<'a> Parser<'a> { | |||
| let (fields, etc) = self.parse_pat_fields().unwrap_or_else(|mut e| { | |||
| e.emit(); | |||
| self.recover_stmt(); | |||
| (vec![], false) | |||
| (vec![], true) | |||
There was a problem hiding this comment.
Testing my understanding: this is getting assigned to the name etc; so, the mechanism here is that we're pretending that struct patterns that failed to parse have a .. so that we shouldn't emit additional errors about missing fields?
|
Looks like I need to keep better track of my review queue. 😰 r? @zackmdavis @bors r+ |
|
📌 Commit 6cd6759 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 28, 2019
…davis Do not complain about unmentioned fields in recovered patterns When the parser has to recover from malformed code in a pattern, do not complain about missing fields. Fix rust-lang#59145.
bors
added a commit
that referenced
this pull request
Mar 28, 2019
Rollup of 12 pull requests Successful merges: - #57987 (Fix some AArch64 typos) - #58581 (Refactor generic parameter encoder functions) - #58803 (fs::copy() unix: set file mode early) - #58848 (Prevent cache issues on version updates) - #59198 (Do not complain about unmentioned fields in recovered patterns) - #59351 (Include llvm-ar with llvm-tools component) - #59413 (HirIdify hir::ItemId) - #59441 (Remove the block on natvis for lld-link.) - #59448 (Use consistent phrasing for all macro summaries) - #59456 (Add documentation about `for` used as higher ranked trait bounds) - #59472 (Document that `std::io::BufReader` discards contents on drop) - #59474 (Fix link capitalization in documentation of std::io::BufWriter.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the parser has to recover from malformed code in a pattern, do not
complain about missing fields.
Fix #59145.